Skip to content

Note about trailing-slash when using Finder with FTP #9264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

chucky2305
Copy link
Contributor

Added a short note on how to use the finder with FTP. There was nothing written about the need of the trailing slash.

Added a short note on how to use the finder with FTP. There was nothing written about the need of the trailing slash.
@javiereguiluz
Copy link
Member

@chucky2305 thanks for contributing to Symfony Docs. Sadly I don't fully understand the explanation -> "... Even if you don`t specify a path ..." But you are specifying a path! So, which are the conditions under you should add a trailing slash? Maybe a link to the Symfony code would be enough for us to fully understand this. Thanks!

@chucky2305
Copy link
Contributor Author

Sorry. After reading it again, i think my words were not clear enough. I tried to make i more clear now. Is it sufficient now?

@javiereguiluz
Copy link
Member

@chucky2305 thanks for latest changes. I've reworded things a bit to add your comment just before the code. We do this in other docs to make contents more concise and to show the help notes just where you need them. By the way, we merged this in 2.7 branch, which is the oldest maintained branch where this fix applies. That's why GitHub shows it as "closed" instead of "merged" ... but it's merged. Finally, congrats on your first Symfony Docs contribution!

javiereguiluz added a commit that referenced this pull request Feb 15, 2018
…cky2305, javiereguiluz)

This PR was submitted for the 4.0 branch but it was merged into the 2.7 branch instead (closes #9264).

Discussion
----------

Note about trailing-slash when using Finder with FTP

Added a short note on how to use the finder with FTP. There was nothing written about the need of the trailing slash.

Commits
-------

1b9f488 Reword
0ff04fd Update finder.rst
8a8ba4f Update finder.rst
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants